🌱 Improve TestReconcileMachinePoolMachines unit test

[cahillsf]

What this PR does / why we need it:

we can see in the failing test results (i.e. https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-test-mink8s-main/1830171842158006272) that this line

cluster-api/exp/internal/controllers/machinepool_controller_phases.go

Line 437 in 703cc70

log.Info("Creating new Machine for infraMachine", "infraMachine", klog.KObj(infraMachine))

is only logging once, whereas in the successful tests (example) , it logs twice as 2 infraMachines are recognized and the 2 machinepool machines are created accordingly

my theory is that a cache sync delay is causing this flake as only 1 of the expected infraMachines is found in the cache when reconcileMachines gets called

this pr updates the method called to Create objects in this set of unit test to the "preferred" method:

• CreateAndWait:

"CreateAndWait creates the given object and waits for the cache to be updated accordingly."

instead of Create()

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11070
(hopefully)

/area machinepool

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[fabriziopandini]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 552ec153c4b4c9a253cf1760032ec62f9cc54b74

[sbueringer]

I don't really get the change from APIReader to Client. APIReader directly accesses the apiserver, Client uses a cache.

So I don't see how switching to Client makes the tests more stable (probably it will make it more flaky)

[cahillsf]

I don't really get the change from APIReader to Client. APIReader directly accesses the apiserver, Client uses a cache.

So I don't see how switching to Client makes the tests more stable (probably it will make it more flaky)

I think you’re right, will revert this change

[sbueringer]

Thank you!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0294a7af8986abdbfef884214036112bd5577758

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment