flaking unit test in TestReconcileMachinePoolMachines

[cahillsf]

Which jobs are flaking?

these failures are apparent in periodic-cluster-api-test-mink8s-main and periodic-cluster-api-test-main

Which tests are flaking?

TestReconcileMachinePoolMachines/Reconcile_MachinePool_Machines/Should_create_two_machines_if_two_infra_machines_exist

Since when has it been flaking?

at least since 20214-07-06: https://storage.googleapis.com/k8s-triage/index.html?date=2024-07-20&text=TestReconcileMachinePoolMachines%2FReconcile_MachinePool_Machines%2FShould_create_two_machines_if_two_infra_machines_exist&job=.*cluster-api.*(test%7Ce2e)-(mink8s-)*main&xjob=.*-provider-.*

Testgrid link

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-test-mink8s-main/1824877164462346240

Reason for failure (if possible)

No response

Anything else we need to know?

No response

Label(s) to be applied

/kind flake
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

[cahillsf]

/area machinepool

[sbueringer]

Yup. I saw a bunch of flakes around MachinePool unit tests as well

/triage accepted

/help

[k8s-ci-robot]

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Yup. I saw a bunch of flakes around MachinePool unit tests as well

/triage accepted

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cahillsf]

/assign cahillsf

cannot reproduce this issue locally, have opened a draft that seems to use preferred methods in this unit test, see PR for details. hopefully this will improve the stability of this test

[sbueringer]

Would be great if some folks familiar with Machine Pools / MachinePool Machines can review #11124

(cc @Jont828 @willie-yao)

[sbueringer]

/reopen

I assume we want to keep this issue open for now as we're not sure if the PR will fix all flakes

[k8s-ci-robot]

@sbueringer: Reopened this issue.

In response to this:

/reopen

I assume we want to keep this issue open for now as we're not sure if it will fix all flakes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cahillsf]

/reopen

I assume we want to keep this issue open for now as we're not sure if the PR will fix all flakes

Yep sounds good, will track the test and revisit

---

edit: adding k8s-triage link https://storage.googleapis.com/k8s-triage/index.html?text=TestReconcileMachinePoolMachines&job=.*cluster-api-(test%7Ce2e)-(mink8s-)*main

[cahillsf]

revisiting this, test hasn't flaked since 9/1 prior to the attempted fix being merged: https://storage.googleapis.com/k8s-triage/index.html?date=2024-09-15&text=TestReconcileMachinePoolMachines&job=.*cluster-api-(test%7Ce2e)-(mink8s-)*main

if we update the date for today the failures are out of the default lookback window: https://storage.googleapis.com/k8s-triage/index.html?date=2024-09-18&text=TestReconcileMachinePoolMachines&job=.*cluster-api-(test%7Ce2e)-(mink8s-)*main

not sure how long we want to wait before closing out this issue @sbueringer ?

[sbueringer]

I think we can close the issue, the flake was pretty frequent before, so I think we have enough data to be sure it's fixed.

Thx for fixing this flake!

/close

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

I think we can close the issue, the flake was pretty frequent before, so I think we have enough data to be sure it's fixed.

Thx for fixing this flake!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.