Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 test: add dynamic finalizer assertions for e2e framework #10003

Conversation

adityabhatia
Copy link
Contributor

Manual cherry-pick of #9970

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #9969

/area testing

@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jan 15, 2024
@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 15, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adityabhatia adityabhatia changed the title [release1.6] test: add dynamic finalizer assertions for e2e framework :seeding: [release1.6] test: add dynamic finalizer assertions for e2e framework Jan 15, 2024
@adityabhatia adityabhatia changed the title :seeding: [release1.6] test: add dynamic finalizer assertions for e2e framework 🌱 [release1.6] test: add dynamic finalizer assertions for e2e framework Jan 15, 2024
@adityabhatia
Copy link
Contributor Author

adityabhatia commented Jan 15, 2024

Note: This PR doesn't contain the Kind conflict addressed here. IMO it also makes sense to cherry-pick that change, to avoid any namespaced name collisions?
I can create a 1.6 cherry-pick once this PR is merged, to avoid conflicts.
cc: @sbueringer

@sbueringer sbueringer changed the title 🌱 [release1.6] test: add dynamic finalizer assertions for e2e framework [release-1.6] 🌱 test: add dynamic finalizer assertions for e2e framework Jan 15, 2024
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2024
@sbueringer
Copy link
Member

sbueringer commented Jan 15, 2024

Note: This PR doesn't contain the Kind conflict addressed here. IMO it also makes sense to cherry-pick that change, to avoid any namespaced name collisions? I can create a 1.6 cherry-pick once this PR is merged, to avoid conflicts. cc: @sbueringer

Agree, thx! I'll cherry-pick the other one with the bot then a quick rebase on this PR should be fine (#10004)

@adityabhatia adityabhatia force-pushed the dynamicFinalizerAssertions1.6 branch from 8fd44df to bca44c5 Compare January 15, 2024 17:53
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b1a36f5cab9b5ed619518f61c68371d80ef5ae5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6078be4 into kubernetes-sigs:release-1.6 Jan 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants