-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] 🌱 test: add dynamic finalizer assertions for e2e framework #10003
[release-1.6] 🌱 test: add dynamic finalizer assertions for e2e framework #10003
Conversation
Hi @adityabhatia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: This PR doesn't contain the Kind conflict addressed here. IMO it also makes sense to cherry-pick that change, to avoid any namespaced name collisions? |
Agree, thx! I'll cherry-pick the other one with the bot then a quick rebase on this PR should be fine (#10004) |
8fd44df
to
bca44c5
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: 3b1a36f5cab9b5ed619518f61c68371d80ef5ae5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manual cherry-pick of #9970
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #9969
/area testing