Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic assertions for finalisers e2e test #9969

Closed
adityabhatia opened this issue Jan 9, 2024 · 1 comment
Closed

Dynamic assertions for finalisers e2e test #9969

adityabhatia opened this issue Jan 9, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adityabhatia
Copy link
Contributor

adityabhatia commented Jan 9, 2024 •
edited
Loading

What would you like to be added (User Story)?

As a user/operator I would like to assert finalisers on provider specific resources, using the e2e framework from CAPI. It is thought of as an addition to the current implementation.

Also, missing finalizer assertions could be added as part of this implementation. e.g. MachinePool, DockerMachinePool.

Detailed Description

  • Dynamic assertion for finaliser reconciliation, for the e2e test framework
  • Add missing finaliser assertions for e2e tests

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
@adityabhatia adityabhatia mentioned this issue Jan 9, 2024
Merged
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
This was referenced Jan 9, 2024
Closed
Merged
@adityabhatia adityabhatia mentioned this issue Jan 26, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @adityabhatia @k8s-ci-robot