Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: self hosted e2e test #5288

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Jan 20, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

The self hosted e2e was failing as the control plane node was encountering disk pressure. This caused CAPA to be evicted and the CAPA images on the original node where deleted to reclaim disk space. When CAPA moved back to the node the image couldn't be found.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5252

Special notes for your reviewer:

Tested this locally:

image

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix self hosted e2e test caused by disk pressure.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@richardcase richardcase changed the title 🐛 fix: self hosted e2e TEst 🐛 fix: self hosted e2e test Jan 20, 2025
@richardcase
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(but seems not fully succeeding yet?)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@richardcase
Copy link
Member Author

(but seems not fully succeeding yet?)

Yeah still a bit flakey. I know the fix works locally so i will monitor this.

@AndiDog
Copy link
Contributor

AndiDog commented Jan 20, 2025

Seems there was still a node not having the E2E image: failing capa pod artifact

The self hosted e2e was failing as the control plane node was
encountering disk pressure. This caused CAPA to be evicted and the CAPA
images on the original node where deleted to reclaim disk space. When
CAPA moved back to the node the image couldn't be found.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member Author

https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5288/pull-cluster-api-provider-aws-e2e/1881316234645999616/artifacts/clusters/self-hosted-2ka0nh/resources/Node/ip-10-0-160-246.us-west-2.compute.internal.yaml is still missing the e2e image, and the node shows no disk pressure 🤔

I misunderstood the "generated" cluster definitions process, so the root volume size wasn't being added. Just testing a change to that.

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member Author

@nrb
Copy link
Contributor

nrb commented Jan 20, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc7ae37 into kubernetes-sigs:main Jan 20, 2025
21 checks passed
@richardcase
Copy link
Member Author

/cherrypick release-2.7

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5293

In response to this:

/cherrypick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member Author

/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5294

In response to this:

/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5295

In response to this:

/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5296

In response to this:

/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI pivot test always case failing in e2es
5 participants