-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated NodeSelector #743
Update deprecated NodeSelector #743
Conversation
Welcome @dschunack! |
Hi @dschunack. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @Ashley-wenyizha @justinsb, this is only a small PR to replace deprecated NodeSelectors. Would be nice, if you Approve the PR. |
Kindly ping @Ashley-wenyizha @wongma7 @justinsb 🙂 |
Signed-off-by: dschunack <dschunack@web.de>
/assign @jsafrane |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dschunack, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,7 +1,7 @@ | |||
apiVersion: v2 | |||
name: aws-efs-csi-driver | |||
version: 2.2.9 | |||
appVersion: 1.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we changing here before a new release?
Signed-off-by: dschunack dschunack@web.de
Is this a bug fix or adding new feature?
No, it replaced the deprecated NodeSelector labels #741
What is this PR about? / Why do we need it?
It replaced the deprecated NodeSelector labels #741
What testing is done?
helm chart was applied on a test EKS