-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated NodeSelector #741
Comments
PR created |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi,
beta.kubernetes.io/os is deprecated since v1.14 and it makes no sense to set this hard coded in the template files.
It's better and also best practice to set this in the values.yaml.
The new NodeSelector is kubernetes.io/os.
I can create also a PR for this if you want.
aws-efs-csi-driver/charts/aws-efs-csi-driver/templates/node-daemonset.yaml
Line 39 in c3eaccf
aws-efs-csi-driver/deploy/kubernetes/base/node-daemonset.yaml
Line 24 in 8ef7a33
aws-efs-csi-driver/charts/aws-efs-csi-driver/templates/controller-deployment.yaml
Line 33 in c3eaccf
The text was updated successfully, but these errors were encountered: