Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change controller port 9808->9909 to avoid node/ebs conflict #437

Merged
merged 2 commits into from
May 21, 2021
Merged

Change controller port 9808->9909 to avoid node/ebs conflict #437

merged 2 commits into from
May 21, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented May 3, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? 9808 is a poor choice because ebs asks for the same port. Related regarding hostnetwork true: #436

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2021
wongma7 referenced this pull request May 3, 2021
@jihed
enable hostNetwork on efs-csi-controller
1c47a40
@wongma7 wongma7 force-pushed the hostnetwrokport branch from cb6b36f to 73eebbc Compare May 3, 2021 17:24
@wongma7 wongma7 changed the title Change controller port 9808->9809 to match node port and avoid ebs conflict Change controller port 9808->9909 to avoid node/ebs conflict May 3, 2021
@wongma7 wongma7 force-pushed the hostnetwrokport branch from e344480 to 7c137b7 Compare May 3, 2021 17:30
@kbasv
Copy link

kbasv commented May 3, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kbasv: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wongma7
Copy link
Contributor Author

wongma7 commented May 3, 2021

/test pull-aws-efs-csi-driver-e2e

1 similar comment
@wongma7
Copy link
Contributor Author

wongma7 commented May 7, 2021

/test pull-aws-efs-csi-driver-e2e

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@wongma7 wongma7 mentioned this pull request May 7, 2021
Closed
@wongma7
Copy link
Contributor Author

wongma7 commented May 8, 2021

  /test pull-aws-efs-csi-driver-e2e

@wongma7
Copy link
Contributor Author

wongma7 commented May 8, 2021

/test pull-aws-efs-csi-driver-e2e

@kbasv
Copy link

kbasv commented May 10, 2021

Downgrading efs-utils to v1.28.2 might fix e2e for the time being.

@wongma7
Copy link
Contributor Author

wongma7 commented May 20, 2021

/test pull-aws-efs-csi-driver-e2e

@wongma7
Copy link
Contributor Author

wongma7 commented May 21, 2021

/test pull-aws-efs-csi-driver-unit

@k8s-ci-robot k8s-ci-robot merged commit d9c12e7 into kubernetes-sigs:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jqmichael jqmichael Awaiting requested review from jqmichael

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wongma7 @k8s-ci-robot @kbasv @nckturner