Skip to content

Commit

Permalink
enable hostNetwork on efs-csi-controller
Browse files Browse the repository at this point in the history
  • Loading branch information
@jihed
jihed committed Apr 14, 2021
1 parent c6c2216 commit 1c47a40
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions charts/aws-efs-csi-driver/templates/controller-deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ spec:
annotations: {{ toYaml .Values.node.podAnnotations | nindent 8 }}
{{- end }}
spec:
hostNetwork: true
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{- range .Values.imagePullSecrets }}
Expand Down

4 comments on commit 1c47a40

@jurgen-weber-deltatre
Copy link

@jurgen-weber-deltatre jurgen-weber-deltatre commented on 1c47a40 May 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind doing this?

ebs-node also uses port 9808 for its DS, so if you have both ebs and efs CSI's installed, you have problems (efs controller pods can not schedule since both are binding to host port):

https://github.com/kubernetes-sigs/aws-ebs-csi-driver/search?q=hostNetwork&type=code

@wongma7
Copy link
Contributor

@wongma7 wongma7 commented on 1c47a40 May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jurgen-weber-deltatre In case pod access to instance metadata is blocked (which is recommended for all eks users by eks documentation), need hostnetwork true. However the port being the same is a mistake that could have been avoided. In any case, you have to edit the deployment to fix the port conflict until the port number change is released #436 #437 #438

@wongma7
Copy link
Contributor

@wongma7 wongma7 commented on 1c47a40 May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can set hostNetwork false if it worked fine before. It's debatable whether it should default true (like I said a lot of EKS users will need it but not necessarily all )

@jurgen-weber-deltatre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the end I reverted back to 1.2.1. I would argue the items in the chat should all be configurable instead of hardcoded... but thank you for letting me know, appreciated.

Please sign in to comment.