-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed harcoded NAMESPACE from helm chart #768
Conversation
Welcome @alexandrst88! |
Hi @alexandrst88. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1653
💛 - Coveralls |
I have read a lot of conflicting info about what the best practice is. Removing kube-system hardcode seems correct to me though. |
/ok-to-test |
/approve Looks like this'll break installing via Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandrst88, ayberk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Is this a bug fix or adding new feature?
Override hardcoded
kube-system
namespaceWhat is this PR about? / Why do we need it?
Ability to run helm chart in another namespace, for example
kube-system
could be free out of any mutation or validation webhooks.Should address #621
What testing is done?
Deployed in
example
namespace without issues.