Helm chart should manage namespace more consistently

[TBBle]

/kind bug

What happened?

The Helm chart does not honour the --namespace parameter for Helm, all resources hard-code the kube-system namespace, meaning it's possible to install the Helm chart metadata in a different namespace from the actual resources.

What you expected to happen?

Either:

• The Helm chart honours --namespace and namespaced resources are created in the provided namespace; or
• The Helm chart rendering fails if --namespace is not passed as kube-system.

How to reproduce it (as minimally and precisely as possible)?

kubectl create namespace aws-ebs-csi-driver
helm upgrade --install aws-ebs-csi-driver \
    --namespace aws-ebs-csi-driver \
    --set enableVolumeScheduling=true \
    --set enableVolumeResizing=true \
    --set enableVolumeSnapshot=true \
    https://github.com/kubernetes-sigs/aws-ebs-csi-driver/releases/download/v0.7.1/helm-chart.tgz
kubectl --namespace aws-ebs-csi-driver get daemonset ebs-csi-node

I would expect to see the AWS EBS CSI driver Daemonset in the output of the last command, or for the helm call to fail.

Anything else we need to know?:

I assume that this project currently depends on being installed in kube-system, as it is system-node-critical. So the obvious resolution to me is to add a check to NOTES.txt that fails rendering if .Release.Namespace is not kube-system.

Either way, it would be a more-consistent-with-common-practice chart if all the hard-coded kube-system references in the chart were replaced with .Release.Namespace.

Environment

• Kubernetes version (use kubectl version): N/A
• Driver version: Untested, observed in the Helm chart templates.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[TBBle]

/remove-lifecycle stale

[krmichel]

@ayberk Looks like this didn't get tied to PR #768 and didn't get closed when that was merged.

[ayberk]

/close

[k8s-ci-robot]

@ayberk: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.