Switch to Java 17 for release action.

[brendandburns]

cc @yue9944882

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joshlong]

hi - a propos of nothing: when's the next release planned? We'd love to have it in time for a release next week so that Spring Cloud Kubernetes can befit from these new AOT hints :)

[wind57]

Can I ask how Spring Cloud Kubernetes is going to benefit from these? I don't see anything issue wise related to this in the github repo, unless its an internal thing. Thank you.

[brendandburns]

@joshlong once this merges the release pipeline in github actions should be fixed and we will then immediately cut a release.

I would expect that we should be able to cut a release by Friday at the latest.

@wind57 this specific change doesn't benefit spring, but it unblocks our ability to cut a new release [which got broken, but we didn't notice]. In particular the new release will contain: #2457 which improves aot-graalvm support for this library thanks to @joshlong

[joshlong]

@joshlong once this merges the release pipeline in github actions should be fixed and we will then immediately cut a release.

I would expect that we should be able to cut a release by Friday at the latest.

@wind57 this specific change doesn't benefit spring, but it unblocks our ability to cut a new release [which got broken, but we didn't notice]. In particular the new release will contain: #2457 which improves aot-graalvm support for this library thanks to @joshlong

thank you so very much!

[yue9944882]

oddly when i was trying to import and verify the new snapshot module client-java-spring-aot-integration (just in case bumping to jdk17 breaks any compatibility), the maven central snapshot repo says it doesn't exist:

Could not find artifact io.kubernetes:client-java-spring-aot-integration:jar:17.0.0-SNAPSHOT -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

is it because the uploaded new module takes some time to be present in the central repo?

[yue9944882]

verified, merging in

/lgtm

[brendandburns]

@yue9944882 in my experience it takes ~24h for a package to get uploaded from sonatype to Maven central.

--brendan

[brendandburns]

@joshlong 17.0.0 release has been cut and pushed to sonatype. I would expect it in Maven Central in ~24h

[joshlong]

Congrats! And thank you

[brendandburns]

@yue9944882 @joshlong when I look at maven central, I'm not certain that I see the right files:

https://mvnrepository.com/artifact/io.kubernetes/client-java-spring-integration

Only shows 16.0.2

Can you take a look and see? I'm worried that we may need to do some more modifications to either the pom or the github action.

(or am I not looking in the right place?)

The client itself is there:
https://mvnrepository.com/artifact/io.kubernetes/client-java/17.0.0

[joshlong]

so some of the modules are being deployed but others are not? i see the client-java-spring-aot-integration in the modules stanza in the parent. i just did a mvn -DskipTests install and I see the spring aot integration deployed to my local ~/.m2/repository. so that's a start. guess I need to try to understand the deployment pipeline a bit more, cuz nothing's leaping out to me here in the pom.xm files.

[joshlong]

à propos: is there any output from during the release that gives a clue as to what may have happened?

[joshlong]

hah. i think we got had by a cache issue. different index on a different site shows it's there :)

if I add the following to a spring boot 3 ga app with no repositories specified, and nothing in local ~/.m2/repository, it seems to work:

<dependency>
	<groupId>io.kubernetes</groupId>
	<artifactId>client-java-spring-aot-integration</artifactId>
	<version>17.0.0</version>
</dependency>

indeed, if I add that, and then a few beans, and then run

./mvnw -DskipTests -Pnative native:compile  && ./target/k8s 

it builds a native image and that works! what a time to be alive :)

[brendandburns]

@joshlong great to get the confirmation that it is working and indeed I see them in maven central now. Must have just been replication lag.