Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release.yml #2483

Closed
wants to merge 1 commit into from
Closed

Update release.yml #2483

wants to merge 1 commit into from

Conversation

brendandburns
Copy link
Contributor

Exclude the recent spring-aot work.

cc @yue9944882 @joshlong

Ultimately we'll need to add another build target for the Java17 dependent module...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2022
@brendandburns brendandburns mentioned this pull request Dec 5, 2022
Closed
@yue9944882
Copy link
Member

yue9944882 commented Dec 6, 2022 •
edited
Loading

@brendandburns i noticed the same failure in the uploading-snapshot workflow after we merged #2457 in. how about we fix the snapshot first progressively to verify the change and compatibility?

https://github.com/kubernetes-client/java/actions/runs/3622185964/jobs/6106580628

@yue9944882
Copy link
Member

@brendandburns @joshlong i opened #2484 as an alternative solution which bumps compiling JDK to 17 instead of skipping the new module explicitly

@brendandburns
Copy link
Contributor Author

Closing in favor of #2487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @yue9944882