Add template function "required" for addons #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the template function "required" was only available for OS template scripts, but not for addon manifest templates, which caused the rendering of the built-in addon "backups-restic" to fail. Therefore the "required" template function was moved into package "addons" and made available to the addons manifest templates. Signed-off-by: Daniel Kraus <daniel.kraus@kubermatic.com>
kubermatic-bot
added
release-note
kron4eg
approved these changes
Jan 14, 2022
|
LGTM label has been added. Git tree hash: 17022a0dd0dffcfbb8efe663fcae0be7761603bc
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dakraus, kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the template function "required" was only available for OS
template scripts, but not for addon manifest templates, which caused the
rendering of the built-in addon "backups-restic" to fail. Therefore the
"required" template function was moved into package "addons" and made
available to the addons manifest templates.
Does this PR introduce a user-facing change?: