Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: function "required" not defined #1806

Closed
judge-red opened this issue Feb 4, 2022 · 1 comment
Closed

Addons: function "required" not defined #1806

judge-red opened this issue Feb 4, 2022 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@judge-red
Copy link

What happened:

The addons use a function called required to check whether required parameters/credentials are provided. However, this function doesn't seemto be working as intended:

time="09:48:41 UTC" level=warning msg="Task failed, error was: failed to load and apply the addon \"backups-restic\": failed to load and apply embedded addon: failed to template addons manifest backups-restic.yaml: template: addons-base:8: function \"required\" not defined"

What is the expected behavior:

I should see the string provided to the required function rather than the error above.

How to reproduce the issue:
Specify an embedded addon that requires some parameter or credential without providing them. For example try to install the backups-restic addon without specifying any parameters.

Anything else we need to know?

The required function was added in #1618 as a fix for #1555.

Information about the environment:
KubeOne version (kubeone version): 1.3.3
Operating system: alpine:3.15.0
Provider you're deploying cluster on: OpenStack
Operating system you're deploying on: Flatcar

@judge-red judge-red added kind/bug Categorizes issue or PR as related to a bug. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Feb 4, 2022
@kron4eg
Copy link
Member

kron4eg commented Feb 4, 2022

@judge-red it was fixed in #1737

@kron4eg kron4eg closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Development

No branches or pull requests

2 participants