Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-terraform: open nodeports unconditionally #1535

Merged
merged 1 commit into from
Sep 22, 2021
Merged

aws-terraform: open nodeports unconditionally #1535

merged 1 commit into from
Sep 22, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 22, 2021

What this PR does / why we need it:
Conformance tests require NodePorts to be open on all node Address types

Does this PR introduce a user-facing change?:

AWS terraform config opens nodeports unconditionally

@kron4eg
aws-terraform: open nodeports unconditionally
6041201 
Conformance tests require NodePorts to be open on all node Address types

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d7509a8326bc8fa4e17856fb3f7d31e51931c6d

@kubermatic-bot kubermatic-bot merged commit 2533166 into kubermatic:master Sep 22, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Sep 22, 2021
@kron4eg kron4eg deleted the aws-node-ports-condition branch September 22, 2021 16:13
@xmudrii xmudrii mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii