Skip to content

Commit

Permalink
aws-terraform: open nodeports unconditionally (#1535)
Browse files Browse the repository at this point in the history
Conformance tests require NodePorts to be open on all node Address types

Signed-off-by: Artiom Diomin <kron82@gmail.com>
  • Loading branch information
kron4eg authored Sep 22, 2021
1 parent abac2b9 commit 2533166
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion examples/terraform/aws/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ resource "aws_security_group_rule" "egress_allow_all" {
}

resource "aws_security_group_rule" "nodeports" {
count = var.open_nodeports ? 1 : 0
type = "ingress"
security_group_id = aws_security_group.common.id

Expand Down
6 changes: 0 additions & 6 deletions examples/terraform/aws/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,6 @@ variable "internal_api_lb" {
type = bool
}

variable "open_nodeports" {
default = false
description = "open NodePorts flag"
type = bool
}

variable "initial_machinedeployment_replicas" {
default = 1
description = "number of replicas per MachineDeployment"
Expand Down

0 comments on commit 2533166

Please sign in to comment.