-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to KFP End-to-end tutorial (Issue #860) #890
Conversation
Updates from #860. Includes proposals 1-4.
Restoring "Handy environment variables" so we don't lose the thread on establishing regions/zones.
Adding a short link/variable for the the kubeflow version number cited in pipeline-tutorial.
Updating kubeflow version number in "Deploy Kubeflow" procedure with HTML tag.
Hi @OfficePop. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
1. Grant users access to kubeflow with the `Owner` and `IAP-secured Web App User` roles: | ||
|
||
``` | ||
gcloud projects add-iam-policy-binding <PROJECT> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this script block. I was wrong, project owner cannot be granted from the command line. They need to use Cloud Console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted this, removing the 'Owner' part but leaving the IAP role. Or do they all need to be removed?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merging this content with getting-started.md
Co-Authored-By: Joe Liedtke <joe.liedtke@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Believe I fixed my mismatched email rules between this account and my CLA on file, adding this comment so the bot runs again. |
Turns out I had to update the CLA too. That has been done as well. |
Co-Authored-By: Joe Liedtke <joe.liedtke@gmail.com>
Co-Authored-By: Joe Liedtke <joe.liedtke@gmail.com>
/ok-to-test |
Syncing fork with main repository
Merging this content with getting-started.md
Had some merge conflicts and CLA issues. Closing this PR and issuing a new one to go more smoothly. |
New PR: #915 |
In response to kubeflow/website issue 860, I have made the following edits to the KFP end-to-end GCP tutorial:
Updated with recommended kubeflow version from 0.4.1 to 0.5.1 with an html tag (html page has also been added in this PR). In the future, this can be handled by updating the embedded html page instead of directly updating the tutorial.
Revised the overview to recommend the user start with Cloud Shell instead of installing Cloud SDK. This reduces the steps the user needs to take and eliminates a potential chokepoint from errors installing or configuring a local copy of the SDK.
Removed the instructions to install kubectl locally, as it is already present in Cloud Shell. References to the local copy of kubectl were revised as well. After discussion with joeliedtke it was agreed to retain the “handy environment variables” procedure when it was identified that it had dependencies later in the tutorially (mainly the user selecting their region/zone).
Instructions for granting user access were added to the “Set up your GCP account and SDK” procedure, along with the required roles and a reference link to the full procedure.
The commands
apt-get install -y
andwget bzip2
were removed from the “Set up Python” procedure.A note was added at the end of the “Run the Pipeline” procedure to help the user locate the data for the trained model.
The only item that was not addressed from the original issue was item 6. This requires more familiarity with all aspects of the tutorial than I can provide at this time, and I recommend it be further fleshed out in another issue.
Also, I would suggest updating the screenshot in the “Deploy Kubeflow” procedure. The version number reads “0.4.1”, which out of date. If possible it would be preferable to update it to something generic like and reduce future maintenance.
I have also appended updates related to kubeflow/website issue 845, merging the content from requirements.md into getting-started.md, updating the _redirects page, and deleting requirements.md.
This change is