Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge requirements into getting-started page #845

Closed
sarahmaddox opened this issue Jun 27, 2019 · 11 comments
Closed

Merge requirements into getting-started page #845

sarahmaddox opened this issue Jun 27, 2019 · 11 comments

Comments

@sarahmaddox
Copy link
Contributor

Merge the "requirements" page (https://www.kubeflow.org/docs/started/requirements/) into the getting-started guide (https://www.kubeflow.org/docs/started/getting-started/) and add the appropriate redirect.

@sarahmaddox sarahmaddox added the doc-sprint Issues to work on during the Kubeflow Doc Sprint label Jun 27, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sarahmaddox
Copy link
Contributor Author

I've marked this one for tackling during the Kubeflow Doc Sprint. This is a good task for a tech writer to tackle during the sprint.

@OfficePop
Copy link
Contributor

This one seems like a good place to get started, please assign it to me when you have a chance!

@sarahmaddox
Copy link
Contributor Author

/assign @OfficePop

@OfficePop
Copy link
Contributor

OfficePop commented Jul 10, 2019

Changes have been added to kubeflow/website PR 923.

@OfficePop
Copy link
Contributor

Did someone else resolve this issue? Had to remove the related updates from my original PR because it was causing merge conflicts. If it's still outstanding, let me know and i'll submit a separate PR for it once the original is handled.

@sarahmaddox
Copy link
Contributor Author

This issue is not yet resolved. The page is still in the docs:
https://www.kubeflow.org/docs/started/requirements/

As far as I know there's no PR in flight to move the content to the getting-started page.

There was a change to the requirements page, that swapped ksonnet to kustomize. That change probably caused the merge conflict.

Please do go ahead with this change, if you have the bandwidth.

@OfficePop
Copy link
Contributor

Excellent, I've edited the previous comment with current PR.

@joeliedtke
Copy link
Member

Glad to be wrong on this, thanks for adding that change in OfficePop

@sarahmaddox
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sarahmaddox sarahmaddox added doc-sprint-2019-07 and removed doc-sprint Issues to work on during the Kubeflow Doc Sprint labels Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants