Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checking status API name #1117

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Update checking status API name #1117

merged 1 commit into from
Dec 18, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Dec 18, 2019

As @johnugeorge commented in kubeflow/pytorch-operator#240, the PR is update the API name as well for tfjob python client. Thanks.


This change is Reviewable

@jinchihe
Copy link
Member Author

/assign @johnugeorge

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.512% when pulling 032e8af on jinchihe:update_api_name into f448d5f on kubeflow:master.

@TravisBuddy
Copy link

Hey @jinchihe,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 509057d0-2162-11ea-a044-67124c782b74

@jinchihe jinchihe changed the title Update check status API name Update checking status API name Dec 18, 2019
@gaocegege
Copy link
Member

/lgtm

@jinchihe
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ca86677 into kubeflow:master Dec 18, 2019
@jinchihe jinchihe deleted the update_api_name branch December 18, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants