Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Add more APIs for SDK #240

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Dec 17, 2019

From feedback, as done for the kubeflow-tfjob SDK, add more APIs for kubeflow-pytorchjob:

  • wait_for_job: Wait for the specified job to finish
  • wait_for_condition: Waits until any of the specified conditions occur
  • get_job_status: Quick way to get the PyTorchJob status
  • is_job_running: Quick way to check if the PyTorchJob status is Running
  • is_job_succeeded: Quick way to check if the PyTorchJob status is Succeeded

@jinchihe jinchihe changed the title Add more APIs for SDK WIP: Add more APIs for SDK Dec 17, 2019
@coveralls
Copy link

coveralls commented Dec 17, 2019

Coverage Status

Coverage remained the same at 22.97% when pulling e0a5820 on jinchihe:add_wait_sdk_api into 26f9d0c on kubeflow:master.

@jinchihe jinchihe changed the title WIP: Add more APIs for SDK Add more APIs for SDK Dec 18, 2019
@jinchihe
Copy link
Member Author

/cc @gaocegege @johnugeorge
Could you please take a look? Thanks a lot!

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@johnugeorge
Copy link
Member

Great.
Do you think, if is_job_running makes more sense than if_job_running? Similarly for if_job_succeeded ?

@jinchihe
Copy link
Member Author

@johnugeorge Great comments. Agree with you, is_job_running better than if_job_running, I'm going to update, and I'm also going to update TFJob side. Thanks!

@jinchihe
Copy link
Member Author

@johnugeorge Updated, Thanks.

@jinchihe
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

@jinchihe Can you please update the PR comment too to reflect the new function names - #240 (comment)

@jinchihe
Copy link
Member Author

@jinchihe Can you please update the PR comment too to reflect the new function names - #240 (comment)

Updated, thanks!

@johnugeorge
Copy link
Member

Thanks @jinchihe
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f117363 into kubeflow:master Dec 19, 2019
@jinchihe jinchihe deleted the add_wait_sdk_api branch December 19, 2019 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants