Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --ingress-class-name to be specified in chart #2278

Merged

Conversation

jacobsalway
Copy link
Member

Purpose of this PR

  • Allow the --ingress-class-name argument to be specified to the controller. This is currently not exposed.

Related: #2276

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
@jacobsalway jacobsalway force-pushed the ingress-class-name-helm-chart branch from b36853d to 95d2821 Compare October 22, 2024 10:56
@jacobsalway jacobsalway marked this pull request as ready for review October 22, 2024 11:03
@jacobsalway
Copy link
Member Author

/assign @ChenYi015 @ImpSy

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 23, 2024
@google-oss-prow google-oss-prow bot merged commit 345d611 into kubeflow:master Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants