Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Supporting nginxinc ingress #2276

Open
aaronfeng opened this issue Oct 21, 2024 · 3 comments
Open

[QUESTION] Supporting nginxinc ingress #2276

aaronfeng opened this issue Oct 21, 2024 · 3 comments
Labels
question Further information is requested

Comments

@aaronfeng
Copy link

spark-operator currently outputs kubernetes/ingress-nginx ingress. Unfortunately we use nginxinc/kubernetes-ingress within our cluster. Since both ingress has the same name, I don't believe it can co-exist within the same cluster. Any thoughts on also supporting nginxinc's version?

@aaronfeng aaronfeng added the question Further information is requested label Oct 21, 2024
@jacobsalway
Copy link
Member

jacobsalway commented Oct 22, 2024

I assume you're referring to the ingress class name? If so the controller supports passing this as a CLI argument however I just noticed it's not exposed in the Helm chart. I'm sure there's more work we can do to support different ingress types but for the immediate case, would being able to specify the ingress class name solve your issue? I'll raise a PR to do so regardless.

https://github.com/kubeflow/spark-operator/blob/master/cmd/operator/controller/start.go#L155

@aaronfeng
Copy link
Author

There are two different nginx ingress controllers with the same name. One is maintained by Kubernetes (what spark-operator supports) and nginx ingress maintained by the nginx company (nginxinc). Both controllers have the same ingress class name ('nginx'). What spark-operator is writing out doesn't work with nginxinc ingress since the annotations and host section is slightly different. I don't think specifying ingress class will work in this case since both ingress controllers have the same exact name and different specifications.

@aaronfeng
Copy link
Author

@jacobsalway Just following up on this. I don't think what you described will fix the issue we are facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants