-
Notifications
You must be signed in to change notification settings - Fork 143
ConvertPyTorchJobToUnstructured uses function ToUnstructured to convert PyTorchJob to Unstructured instead of json #241
Conversation
Generate Kubeflow PyTorchJob SDK (kubeflow#227)
fix(job_test) test case should not include worker service (kubeflow#231)
feat(deletePodsAndServices):only delete master service (kubeflow#233)
… uses function ToUnstructured to convert PyTorchJob to Unstructured instead of json
kubeflow
Hi @leileiwan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks for your contribution! 🎉 👍 /lgtm |
@leileiwan Can you also add it to tf-operator repo too? https://github.com/kubeflow/tf-operator/blob/master/pkg/common/util/v1/testutil/util.go |
ok,iwill |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the PR kubernetes/kubernetes#86291 we use json to convert PyTorchJob to Unstructured ,the test case will not pass. The code has potential problem.
so, I suggest to use function ToUnstructured to instead of json