Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Generate Kubeflow PyTorchJob SDK #227

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Dec 9, 2019

Discussed in kubeflow/training-operator#167, and requried by @johnugeorge.

The PR is includes:

  • Generated PyTorchJob Python SDK from the way: Go type -> openapi -> swagger file -> PyTorch SDK.
  • Manually update the SDK name to kubeflow-pytorchjob and from kubeflow import pytorchjob.
  • Manually added some Client APIs such as create, get, update, delete ...
  • Release frist version kubeflow-pytorch SDK to Pypi: https://pypi.org/project/kubeflow-pytorchjob/
  • Drafted some docs and updated Readme file.
  • Created a sample for the SDK usage.
  • Added some CI tests for the SDK.
  • Work around some testing problem below.

Next:

@coveralls
Copy link

coveralls commented Dec 9, 2019

Coverage Status

Coverage decreased (-62.4%) to 22.97% when pulling 1a30426 on jinchihe:generate_sdk into 5522f91 on kubeflow:master.

@jinchihe
Copy link
Member Author

jinchihe commented Dec 10, 2019

Failed to set kubeflow in CI test.

level=error msg="validating registry URL: validating GitHub registry URL: \"https://github.com/kubeflow/kubeflow/tree/master/kubeflow/reg
istry.yaml\" actual 404; expected 200"

Seems this caused by kubeflow/kubeflow#4484, the ksonnet registry has been removed, we need to enhance this.

@jinchihe jinchihe force-pushed the generate_sdk branch 9 times, most recently from 299c7ca to 94e2a96 Compare December 10, 2019 10:00
@jinchihe jinchihe changed the title WIP: Generate Kubeflow PyTorchJob SDK Generate Kubeflow PyTorchJob SDK Dec 10, 2019
@jinchihe
Copy link
Member Author

/assign @johnugeorge @gaocegege
/cc @animeshsingh @richardsliu @jlewi

The PR is ready for reviewing now, please see the PR description section for details. Thanks a lot!

@johnugeorge
Copy link
Member

Looks great. Thanks @jinchihe for this contribution

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c295893 into kubeflow:master Dec 10, 2019
leileiwan added a commit to leileiwan/pytorch-operator that referenced this pull request Dec 11, 2019
Generate Kubeflow PyTorchJob SDK (kubeflow#227)
@jinchihe jinchihe deleted the generate_sdk branch December 11, 2019 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants