Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

adds sdk for pytorchjob from OpenAPI Spec #180

Closed
wants to merge 2 commits into from

Conversation

swiftdiaries
Copy link
Member

Similar issue in tf-operator: kubeflow/training-operator#167
I'll follow-up with another PR to create the actual client sdk.

/cc @johnugeorge @richardsliu

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gaocegege
You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jun 20, 2019

Coverage Status

Coverage decreased (-84.4%) to 0.837% when pulling b7fe50f on swiftdiaries:openapi-spec into 213df9c on kubeflow:master.

@swiftdiaries
Copy link
Member Author

/hold

@swiftdiaries
Copy link
Member Author

I'm not seeing a diff in the v1beta2 and v1 APISpec for the operator, is this expected?

@swiftdiaries swiftdiaries changed the title adds openapi-spec for pytorchjob adds sdk for pytorchjob from OpenAPI Spec Jun 20, 2019
@jinchihe
Copy link
Member

@swiftdiaries Would you mind to close this PR? That has been implemented in the #227 Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants