Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependency in bazel BUILD #883

Merged
merged 1 commit into from
Mar 1, 2019
Merged

add missing dependency in bazel BUILD #883

merged 1 commit into from
Mar 1, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 1, 2019

caught this by running bazel build //backend/... from root


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Mar 1, 2019

/assign @neuromage

@neuromage
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Mar 1, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4906ef4 into master Mar 1, 2019
@IronPan IronPan deleted the test branch March 27, 2019 17:55
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Create periodic job for infra-viewer access sync
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
- Use default `step` value: `1` in case of `0` provided in `PipelineLoop`.

Issue: kubeflow/kfp-tekton#882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants