Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: runtime error: integer divide by zero #882

Closed
rafalbigaj opened this issue Mar 18, 2022 · 0 comments · Fixed by #883
Closed

panic: runtime error: integer divide by zero #882

rafalbigaj opened this issue Mar 18, 2022 · 0 comments · Fixed by #883
Labels

Comments

@rafalbigaj
Copy link
Contributor

/kind bug

What steps did you take and what happened:
When PipelineLoop step is set to 0, the process panics with:

goroutine 62 [running]:
github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun.computeIterations(0xc0009b01c0, 0xc0009b01c0)
	github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops@v0.0.0-20220120185053-793854829e7e/pkg/reconciler/pipelinelooprun/pipelinelooprun.go:812 +0x6da
github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun.(*Reconciler).reconcile(0xc0002d48a0, {0x2893258, 0xc003807a40}, 0xc00381e240, 0xc0037e72a8)
	github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops@v0.0.0-20220120185053-793854829e7e/pkg/reconciler/pipelinelooprun/pipelinelooprun.go:310 +0x169
github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops/pkg/reconciler/pipelinelooprun.(*Reconciler).ReconcileKind(0x0, {0x2893258, 0xc003807a40}, 0xc00381e240)
	github.com/kubeflow/kfp-tekton/tekton-catalog/pipeline-loops@v0.0.0-20220120185053-793854829e7e/pkg/reconciler/pipelinelooprun/pipelinelooprun.go:180 +0xcb5
github.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1alpha1/run.(*reconcilerImpl).Reconcile(0xc000d51400, {0x2893258, 0xc003807a10}, {0xc003815180, 0x64})
	github.com/tektoncd/pipeline@v0.32.1/pkg/client/injection/reconciler/pipeline/v1alpha1/run/reconciler.go:239 +0x6d7
knative.dev/pkg/controller.(*Impl).processNextWorkItem(0xc0002d5740)
	knative.dev/pkg@v0.0.0-20220302134643-d2cdc682d974/controller/controller.go:535 +0x5a5
knative.dev/pkg/controller.(*Impl).RunContext.func3()
	knative.dev/pkg@v0.0.0-20220302134643-d2cdc682d974/controller/controller.go:484 +0x68
created by knative.dev/pkg/controller.(*Impl).RunContext
	knative.dev/pkg@v0.0.0-20220302134643-d2cdc682d974/controller/controller.go:482 +0x2de

What did you expect to happen:

Use default step value: 1 in case of 0 provided.

Additional information:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Python Version (use python --version):
  • SDK Version:
  • Tekton Version (use tkn version): v0.30.1
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):
rafalbigaj added a commit to rafalbigaj/kfp-tekton that referenced this issue Mar 18, 2022
- Use default `step` value: `1` in case of `0` provided in `PipelineLoop`.

Issue: kubeflow#882
google-oss-prow bot pushed a commit that referenced this issue Mar 18, 2022
- Use default `step` value: `1` in case of `0` provided in `PipelineLoop`.

Issue: #882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant