Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): set correct permissions for local directory #7916

Closed
wants to merge 1 commit into from
Closed

fix(backend): set correct permissions for local directory #7916

wants to merge 1 commit into from

Conversation

larrytin
Copy link

same problem as #7213

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign linchin after the PR has been reviewed.
You can assign the PR to them by writing /assign @linchin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @larrytin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout
Copy link
Member

/ok-to-test

@larrytin
Copy link
Author

larrytin commented Jul 4, 2022

/retest-required

@juliusvonkohout
Copy link
Member

is this related to #6530 and #5673 ?

@larrytin
Copy link
Author

larrytin commented Jul 18, 2022

@juliusvonkohout
yes, this pull request is enough for me to use a non-root image

@larrytin
Copy link
Author

/retest

@juliusvonkohout
Copy link
Member

@zijianjoy this is important for the 2.0 release then, because otherwise it would be a regression.

@rimolive
Copy link
Member

rimolive commented Sep 8, 2023

What is required to merge this PR? I tested the changes in a restricted k8s environment (OpenShift) and these changes look good. With that, we and kfp-tekton team don't need to create SecurityContextContraint objects if this PR is merged.

@rimolive
Copy link
Member

/lgtm

@google-oss-prow
Copy link

@rimolive: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout
Copy link
Member

/lgtm

@juliusvonkohout
Copy link
Member

@rimolive You need to join the KFP meeting to push this PR.

@rimolive
Copy link
Member

@rimolive You need to join the KFP meeting to push this PR.

Thank you, Julius! I've been attending the meetings for a while. I will propose this PR to be reviewed next meeting.

@chensun
Copy link
Member

chensun commented Oct 10, 2023

Same change has merged as #9946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants