Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add http status code check for token requests. Fixes #4312 #5782

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

annajung
Copy link
Member

@annajung annajung commented Jun 2, 2021

Signed-off-by: Anna Jung (VMware) antheaj@vmware.com

Description of your changes:
Add HTTP status code check for token request response and throw an HTTPError instead of KeyError when the returned status is not 2xx

fixes #4312

Checklist:

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@google-oss-robot
Copy link

Hi @annajung. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@annajung
Copy link
Member Author

annajung commented Jun 2, 2021

/assign @Bobgy for review

@Bobgy
Copy link
Contributor

Bobgy commented Jun 3, 2021

/lgtm
/ok-to-test

@chensun do you want to review?

@chensun
Copy link
Member

chensun commented Jun 3, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 0d84877 into kubeflow:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdk/client/auth - KeyError: 'id_token' from _auth.py in id_token_from_refresh_token
5 participants