sdk/client/auth - KeyError: 'id_token' from _auth.py in id_token_from_refresh_token

[Bobgy]

If getting “KeyError: 'id_token'” from “File "/Users/gongyuan/miniconda3/envs/mlpipeline/lib/python3.7/site-packages/kfp/_auth.py", line 192, in id_token_from_refresh_token
return (str(json.loads(res.text)[u"id_token"]))

The request to get id token from refresh token failed, but the client didn’t surface the underlying error message. The http response I got was

{
  "error": "invalid_grant",
  "error_description": "Bad Request"
}

And root cause: ~/.config/kfp/credentials.json has expired. I deleted it and got a new token: rm ~/.config/kfp/credentials.json.

Solution

pipelines/sdk/python/kfp/_auth.py

Lines 184 to 185 in 2a65eec

	res = requests.post(OAUTH_TOKEN_URI, data=payload)
	return (str(json.loads(res.text)[u"refresh_token"]))

and

pipelines/sdk/python/kfp/_auth.py

Lines 191 to 192 in 2a65eec

	res = requests.post(OAUTH_TOKEN_URI, data=payload)
	return (str(json.loads(res.text)[u"id_token"]))

, we should first check request response status code by Response.raise_for_exception, it could be 401 unauthorized.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Bobgy]

/lifecycle frozen

[Bobgy]

/cc @chensun

[annajung]

Picking this up. Let me know if there is any problem in working on this issue. thanks!