feat(deployment): configurable v2 compatible mode default pipeline root. Part of #5680. Fixes #5704 #5750
Conversation
|
/assign @zijianjoy @capri-xiyue |
Bobgy
changed the title
|
/hold |
Bobgy
changed the title
Bobgy
changed the title
Bobgy
changed the title
Bobgy
changed the title
| ## When not in Kubeflow Pipelines multi-user mode, the config works as you | ||
| ## would normally expect. | ||
| ## | ||
| ## In Kubeflow Pipelines multi-user mode, the config creates default |
There was a problem hiding this comment.
Do all namespaces share same default pipeline root path as specified in defaultPipelineRoot field under multi-user mode? How do we control data access if all namespaces share same pipeline root?
There was a problem hiding this comment.
Users can edit the kfp-launcher configmap afterwards and their changes won't be overridden again by this config.
Users can configure different defaultPipelineRoot per namespace in kfp-launcher configmap. Do you have any suggestions to make this part easier to understand?
let me try to clarify in the PR first
There was a problem hiding this comment.
Thank you Yuan for the doc update! I understand it better now. I was originally thinking that how do we programmatically assign a pipeline root for each namespace? For example: gs://{$BUCKET_NAME}/v2/artifact/{$NAMESPACE}. But it seems to be out-of-scope for current version, because we need to edit kfp-launcher-configmap.yaml in each user's namespace.
Also understand it is hard to configure pipeline root based on namespace parameter, the current solution SGTM.
|
@zijianjoy What do you think about the updated documentation? |
|
/unhold |
|
/unhold |
| ## When not in Kubeflow Pipelines multi-user mode, the config works as you | ||
| ## would normally expect. | ||
| ## | ||
| ## In Kubeflow Pipelines multi-user mode, the config creates default |
There was a problem hiding this comment.
Thank you Yuan for the doc update! I understand it better now. I was originally thinking that how do we programmatically assign a pipeline root for each namespace? For example: gs://{$BUCKET_NAME}/v2/artifact/{$NAMESPACE}. But it seems to be out-of-scope for current version, because we need to edit kfp-launcher-configmap.yaml in each user's namespace.
Also understand it is hard to configure pipeline root based on namespace parameter, the current solution SGTM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Part of #5680, Fixes #5704
The field
defaultPipelineRootfield inpipeline-install-configcan be used to configure both multi-user mode and KFP standalone.This PR depends on feature in #5697.
Checklist: