-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): enable v2 compatible mode in full Kubeflow with zero config. Fixes #5680 #5697
Conversation
/assign @capri-xiyue |
/hold EDIT: this doesn't work on kubeflow on GCP, see #5680 (comment) |
/unhold For making default pipeline root work in other distributions, we need a way to configure default pipeline root. |
v2/component/launcher.go
Outdated
} | ||
// LauncherConfig is optional, so it can be nil when err == nil. | ||
if config != nil && config.Data != nil { | ||
defaultRootFromConfig := config.Data["defaultPipelineRoot"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that user defines a configmap but doesn't define the "defaultPipelineRoot" in configmap? Should we throw a error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we treat all configuration with maximum tolerance, e.g.:
- everything should have a default value
- everything is optional
Therefore, I don't throw an error here.
I did add a glog.Infof
afterwards to make it obvious what we defaults to in the end. (our logging doesn't show info logs by default, but we can fix that separately)
What do you think about these choices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes #5680
Investigation and rationale are logged in #5680.
Changes:
defaultPipelineRoot
in a configmap namedkfp-launcher
in the same namespace as the pipeline run.MINIO_SERVICE_SERVICE_HOST
env var. When not found, fallbacks tominio-service.kubeflow:9000
(default service name of MinIO in full Kubeflow).How this PR makes kfp v2 compatible run on Kubeflow:
defaultPipelineRoot
in a configmap namedkfp-launcher
in the same namespace as the pipeline runAs a follow up, #5750 makes defaultPipelineRoot configurable as
defaultPipelineRoot
field inpipeline-install-config
for both KFP standalone and multi-user mode.Checklist: