Support cloning runs created with an embedded pipeline #465
Conversation
|
/test build-image |
|
/test presubmit-e2e-test |
1 similar comment
|
/test presubmit-e2e-test |
| @@ -446,7 +480,6 @@ class NewRun extends Page<{}, NewRunState> { | |||
| return; | |||
| } | |||
| pipeline.parameters[index].value = value; | |||
| // TODO: is this doing anything? | |||
There was a problem hiding this comment.
Note: it's not enough to change the object on the state, setState has to be called in order to update it in the UI.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test presubmit-e2e-test |
* get started testing virtualservice * add transformer and explainer tests * rename to component status map
Updating a few SDK files remaining after kubeflow#463 Related kubeflow#463
Fixes #75.
This PR adds cloning functionality in the
NewRuncomponent to support copying an embedded pipeline in the original run. When such a pipeline is found, switch controls show up (radio button group for now) to allow switching between the cloned run's pipeline, and choosing from the pipeline list.@ajayalfred can you take a look at this? I needed something working that is still usable, feel free to change the design. I won't block the PR on the potential redesign though, we can iterate on it later.
This change is