Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloning run started from notebook #75

Closed
yebrahim opened this issue Nov 6, 2018 · 7 comments
Closed

Support cloning run started from notebook #75

yebrahim opened this issue Nov 6, 2018 · 7 comments

Comments

@yebrahim
Copy link
Contributor

yebrahim commented Nov 6, 2018

Currently, runs have two ways of telling which pipeline was used to start them:

  • Either a pipeline was uploaded to the system first, in which case the run will include its id.
  • Or the run was started from a notebook (or CLI), in which case it will (can) embed the entire pipeline spec.

The UI should be passing that spec when cloning a run that does not have a pipeline id. We need to also figure out the UX, since a user might still be able to change their mind after starting a clone from a run, then want to switch to another pipeline.

@ajayalfred any thoughts here?

@ajayalfred
Copy link
Contributor

The UX ask here is what to display in the 'Pipeline' field when a run created from a Notebook is cloned? As there won't be a pipeline ID to show in the 'Pipeline' field?

And when you say spec is passed, do you mean the pipeline definition in YAML?

@yebrahim
Copy link
Contributor Author

yebrahim commented Nov 6, 2018

Yes, we need to show something in the stead of a pipeline ID, o perhaps the entire selector widget, while enabling the user to still switch back to the selector if they change their mind about cloning.

The pipeline spec is whatever the pipeline definition is as stored by the backend, right now it's indeed a YAML spec.

@ajayalfred
Copy link
Contributor

Spec for handling pipeline column in runs generated from Notebook.

In the pipeline column, replace name with a link 'View pipeline' when a pipeline ID is not available.

image

Selecting the link, takes the user to the pipeline details page with the app bar as show below.

image

No actions to be displayed. We will reassess if actions are needed at a later point. Use 'Experiments > [run name]' breadcrumb to navigate back to the runs list.

@yebrahim
Copy link
Contributor Author

The breadcrumbs should show the run name too, not just the experiment name. This is very important I think, since it's the only usable identifier for this pipeline.

@ajayalfred
Copy link
Contributor

You're correct, I mixed up the breadcrumbs.

With the correct path displayed in breadcrumbs, it's confusing though what the back button will do... since the user arrives on the pipeline page directly from the experiment details page.
image

Alternative is to show the run name in brackets in page title
image

@yebrahim
Copy link
Contributor Author

If the user observed that the back button just does browser back, it won't be confusing at all. It'll take the user back to the previous page (list page), and the breadcrumbs are there in case the user wants to navigate to that run from the pipeline details page.

@ajayalfred
Copy link
Contributor

Ok opt 1 sounds good.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
* init code

* add initial workspace workaround

* added workspaces to pipelinerun

* fix typo

* only use workspace if necessary

* add extra steps for copying non configurable output file path

* update comment

* update container image

* update copy step to use busybox

* update comments

* replace workspaces with emptydir volume

* revert workspace changes

* fix volume edge case

* update comments

* update test report
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants