Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited docstring of ContainerOp to address Issue #2593 #3444

Closed
wants to merge 1 commit into from

Conversation

nihil0
Copy link

@nihil0 nihil0 commented Apr 4, 2020

The documentation of the constructor for ContainerOp is out of date. Now, the artifact paths are no longer automatically included (inferred from #2046).

This is a small fix to address that.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @nihil0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gaoning777
You can assign the PR to them by writing /assign @gaoning777 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nihil0
Copy link
Author

nihil0 commented Apr 4, 2020

/assign @gaoning777

@nihil0
Copy link
Author

nihil0 commented Apr 4, 2020

/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 6, 2020

output_artifact_paths parameter is now deprecated in favor of just file_outputs. For some reason we forgot to merge #2334

@stale
Copy link

stale bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jul 5, 2020
@stale
Copy link

stale bot commented Jul 12, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale The issue / pull request is stale, any activities remove this label. needs-ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants