DEPRECATE(sdk): DSL - Deprecated output_artifact_paths parameter in ContainerOp constructor #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@Ark-kun does this need to get merged? |
… constructor The users should switch to file_outputs instead. Previously `file_outputs` only supported small data outputs, but now it supports big files.
Ark-kun
force-pushed
the
SDK---DSL---Deprecated-output_artifact_paths-parameter-in-ContainerOp-constructor
branch
from
f387c5a
to
fbf1967
Compare
Ark-kun
force-pushed
the
SDK---DSL---Deprecated-output_artifact_paths-parameter-in-ContainerOp-constructor
branch
2 times, most recently
from
f387c5a
to
fbf1967
Compare
…hs-parameter-in-ContainerOp-constructor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
changed the title
Bobgy
changed the title
|
What do you think about the new title? I can add some configuration to make these PRs show up in a separate section in changelog. |
|
/lgtm leave to you to decide title |
Bobgy
added
the
cherrypick-approved
|
/unhold |
|
@Ark-kun how does file outputs support big data passing? What happens if a downstream component refers to the output using inputValue? /cc @paveldournov |
Bobgy
removed
the
cherrypick-approved
Ark-kun
added a commit
to Ark-kun/pipelines
that referenced
this pull request
Oct 25, 2020
Reverting most of the kubeflow#2334 which inadvernetnly broke those artifacts by causing the names to be mangled. KFP's DSL compiler prepends template names to output names to ensure global uniqueness of *input* names (DSL's ContainerOp does not have concept of inputs, so the inputs are generated during the compilation including input names). But prepending template names to the output names stops the backend from recognizing the mlpipeline-ui-metadata and mlpipeline-metrics artifacts.
Ark-kun
added a commit
to Ark-kun/pipelines
that referenced
this pull request
Oct 25, 2020
Reverting most of the kubeflow#2334 which inadvertently broke those artifacts by causing the names to be mangled. KFP's DSL compiler prepends template names to output names to ensure global uniqueness of *input* names (DSL's ContainerOp does not have concept of inputs, so the inputs are generated during the compilation including input names). But prepending template names to the output names stops the backend from recognizing the mlpipeline-ui-metadata and mlpipeline-metrics artifacts.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Oct 26, 2020
Reverting most of the #2334 which inadvertently broke those artifacts by causing the names to be mangled. KFP's DSL compiler prepends template names to output names to ensure global uniqueness of *input* names (DSL's ContainerOp does not have concept of inputs, so the inputs are generated during the compilation including input names). But prepending template names to the output names stops the backend from recognizing the mlpipeline-ui-metadata and mlpipeline-metrics artifacts.
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…ontainerOp constructor (kubeflow#2334) The users should switch to file_outputs instead. Previously `file_outputs` only supported small data outputs, but now it supports big files.
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
Reverting most of the kubeflow#2334 which inadvertently broke those artifacts by causing the names to be mangled. KFP's DSL compiler prepends template names to output names to ensure global uniqueness of *input* names (DSL's ContainerOp does not have concept of inputs, so the inputs are generated during the compilation including input names). But prepending template names to the output names stops the backend from recognizing the mlpipeline-ui-metadata and mlpipeline-metrics artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users should switch to file_outputs instead.
Previously
file_outputsonly supported small data outputs, but now it supports big files.This change is