Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend]Initial execution cache #3036
[Backend]Initial execution cache #3036
Changes from 33 commits
6994984
19a61e7
0448a12
d2fad48
c561ca4
55ee8a7
0f83144
1ecc855
1b5b681
83126c7
ae472d7
8c0cac8
cb075b2
4b0831a
e1bedf7
ed1aa0e
3b1323c
da3eb42
37521ec
5efe589
fa12c40
3c302af
17f714e
79e4711
a16335c
bb796c1
db797b3
57523c0
893e8b1
851ce25
1720ee6
f482c9f
6523570
5c5298e
914d9fd
4e7e3a9
ad560f4
ba26e48
065af7a
a8aa15c
e7aefad
5cebf4e
2ccf3b3
5b65988
2175fb8
65c4f53
a147e19
b282938
75b0c0a
a13c318
86ebe17
e7ba5dc
60972bd
e33cef8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we ever expect user to deploy this manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually deployment is only for cases where users want to have cache service in there current KFP deployment but do not want to deploy KFP from scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in such case they should go through the upgrade process instead which will be a tested path ideally.
cc/ @Bobgy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Yang's reply. It would help keep it in a good status (e.x. binaries in-compaibile with each other, although here it doesn't have the problem now).
I think it's find we leave msg here as it's not website/doc repo (and meanwhile we add sentence mention that we suggest user go though UPGRADE process and provide link to website.