[Backend]Initial execution cache #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds initial execution cache service. Including http service and execution key generation.
|
/assign @Ark-kun @numerology |
numerology
reviewed
Feb 11, 2020
Ark-kun
reviewed
Feb 11, 2020
Ark-kun
reviewed
Feb 11, 2020
Ark-kun
reviewed
Feb 11, 2020
Ark-kun
reviewed
Feb 11, 2020
Ark-kun
reviewed
Feb 14, 2020
This commit adds Dockerfile for building source code and OWNERS file for easy review. This commit also renames some functions.
Ark-kun
reviewed
Feb 15, 2020
|
/lgtm |
This PR fixes changes on go.sum
|
/lgtm |
|
/retest |
|
/lgtm |
…xecution_cache
…into execution_cache
IronPan
reviewed
Mar 3, 2020
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Initial execution cache This commit adds initial execution cache service. Including http service and execution key generation. * Add initial server logic * Add const * Change folder name * Change execution key name * Fix unit test * Add Dockerfile and OWNERS file This commit adds Dockerfile for building source code and OWNERS file for easy review. This commit also renames some functions. * fix go.sum This PR fixes changes on go.sum * Add local deployment scripts This commit adds local deployment scripts which can deploy cache service to an existing cluster with KFP installed. * refactor src code * Add standalone deployment scripts and yamls This commit adds execution cache deployment scripts and yaml files in KFP standalone deployment. Including a deployer which will generate the certification and mutatingwebhookconfiguration and execution cache deployment. * Minor fix * Add execution cache image build in test folder * fix test cloudbuild * Fix cloudbuild * Add execution cache deployer image to test folder * Add copyright * Fix deployer build * Add license for execution cache and cloudbuild for execution cache images This commit adds licenses for execution cache source code. Also adds cloud build step for building cache image and cache deployer image. Change the manifest name based on changed image. * Refactor license intermediate data * Fix execution cache image manifest * Typo fix for cache and cache deployer images * Add arguments in ca generation scripts and change deployer base image to google/cloud * minor fix * fix arg * Mirror source code with MPL in execution_cache image * Minor fix * minor refactor on error handling * Refactor cache source code, Docker image and manifest * Fix variable names * Add images in .release.cloudbuild.yaml * Change execution_cache to generic name * revice readme * Move deployer job out of upgrade script * fix tests * fix tests * Seperate cache service and cache deployer job * mysql set up * Delete cache service in manifest, only test in presubmit tests * fix * fix presubmit tests * fix * fix * revert unnecessary change * fix cache image tag * change image gcr to ml-pipeline-test * Remove namespace in standalone manifest and add to test manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial execution cache service. Including request admission and simple mutate logic which only calculates execution hash key and add this key to the pod.metadata.annotaions.
This PR also adds deployment scripts in standalone deployment. Including execution_cache_deployer job which will generate certifications and MutatingWebhookConfiguration and execution_cache deployment and service yaml.
Part of #2904
This change is