Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Fix the component arguments #2803

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

numerology
Copy link

@numerology numerology commented Jan 6, 2020

Fix some issues surfaced in #2795


This change is Reviewable

@numerology
Copy link
Author

/hold need some manual tests first

@numerology
Copy link
Author

/hold cancel
Looks like it's passing.

This reverts commit 14e2835
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Jan 6, 2020
@gaoning777
Copy link
Contributor

/lgtm

@numerology
Copy link
Author

/retest

1 similar comment
@numerology
Copy link
Author

/retest

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07efee5 into kubeflow:master Jan 7, 2020
@numerology numerology deleted the fix-2697-for-real-for-real branch January 9, 2020 18:07
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* fix position of ui md path

* update image tag

* Revert "update image tag"

This reverts commit 14e2835
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…eflow#2803)

Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.4 to 39.0.1.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@38.0.4...39.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants