Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release cb7342c5c19bfbc2f4f253e7ada9f9ff909594d1 #2795

Closed
wants to merge 4 commits into from
Closed

Release cb7342c5c19bfbc2f4f253e7ada9f9ff909594d1 #2795

wants to merge 4 commits into from

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jan 4, 2020 •
edited by jlewi
Loading

This change is Reviewable

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@IronPan
Copy link
Member

IronPan commented Jan 4, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

3 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link

Seems like the fix in #2779 is not valid. Let me take a look

@numerology
Copy link

@gaoning777 I took a look and it seems like gcr.io/ml-pipeline/ml-pipeline-gcp:a8fcec5f702fc2528c87ed6fd698b9cfca8b509e does not contain the change in #2779 . Can you confirm?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 6, 2020
@gaoning777
Copy link
Contributor Author

I tried to pull the master, merge, and push. Let's see how it goes.

@numerology
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@gaoning777: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test a13c2c3 link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-e2e-test a13c2c3 link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaoning777
Copy link
Contributor Author

/hold
There are bugs in the gcp components.

@numerology
Copy link

Memo:

There are two issues about the invocation style of Python fire right now.

  1. it should be ui_metadata_path instead of ui-metadata-path; and
  2. ui_metadata_path needs to be the first in the argument list.

Will put together a fix shortly.

@numerology numerology mentioned this pull request Jan 6, 2020
Merged
@gaoning777 gaoning777 closed this Jan 7, 2020
@gaoning777
Copy link
Contributor Author

Thanks Jiaxiao for the investigation.

@Bobgy Bobgy deleted the release-cb7342c5c19bfbc2f4f253e7ada9f9ff909594d1 branch June 17, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@IronPan IronPan

@numerology numerology

Labels
approved do-not-merge/hold lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @IronPan @k8s-ci-robot @numerology