Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKL - DSL - Stabilized the PipelineVolume names #2794

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 3, 2020

The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for #2780
Fixes https://travis-ci.com/kubeflow/pipelines/jobs/270786161


This change is Reviewable

The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for kubeflow#2780
Fixes  https://travis-ci.com/kubeflow/pipelines/jobs/270786161
@Ark-kun Ark-kun requested a review from elikatsis January 3, 2020 23:18
@Ark-kun Ark-kun changed the title SDL - DSL - Stabilized the PipelineVolume names SKL - DSL - Stabilized the PipelineVolume names Jan 4, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 4, 2020

/retest

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f39cbdc into kubeflow:master Jan 4, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for kubeflow#2780
Fixes  https://travis-ci.com/kubeflow/pipelines/jobs/270786161
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants