Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Bumping the upper version of Kubernetes package #2780

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Dec 28, 2019

Fixes #2771


This change is Reviewable

@Ark-kun Ark-kun requested a review from gaoning777 December 28, 2019 03:09
Ark-kun added a commit to Ark-kun/pipelines that referenced this pull request Jan 3, 2020
The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for kubeflow#2780
Fixes  https://travis-ci.com/kubeflow/pipelines/jobs/270786161
k8s-ci-robot pushed a commit that referenced this pull request Jan 4, 2020
The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for #2780
Fixes  https://travis-ci.com/kubeflow/pipelines/jobs/270786161
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 4, 2020

The upper version was pinned in #1159
@gaoning777 Do you remember what the breaking change was?

@gaoning777
Copy link
Contributor

It was a while back and I couldn't remember.
If all tests are passing, bumping the version seems good to me.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 7, 2020

Looks like everything is working. @gaoning777 Can you please LGTM?
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jan 9, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit bae654d into kubeflow:master Jan 9, 2020
rui5i pushed a commit to rui5i/pipelines that referenced this pull request Jan 16, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
The name no longer depends on unset parameters or the version of the Kubernetes package.
Needed for kubeflow#2780
Fixes  https://travis-ci.com/kubeflow/pipelines/jobs/270786161
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update feast transformer docs

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Replace docker image username with template and add new schema yaml file

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Use kserve transformer image

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Resolve comments

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

advance k8s sdk requirements
4 participants