Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Align preload TFX sample with TFX head #2526

Merged
merged 1 commit into from
Nov 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/contrib/parameterized_tfx_oss/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Please refer to inline comments for the purpose of each step.
In order to successfully compile this sample, you'll need to have a TFX installation at HEAD.
First, you can clone their repo and run `python setup.py install` from `tfx/`.
The image used in the pipeline is specified as `tfx_image` in the
`KubeflowDagRunnerConfig`. Currently we're using our own patched version of TFX image containing visualization support.
`KubeflowDagRunnerConfig`. Please make sure you use the latest TFX build so that visualization support is included.
List of officially released nightly build image available can be found [here](https://hub.docker.com/r/tensorflow/tfx/tags)).

After that, running
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _create_test_pipeline(pipeline_root: Text, csv_input_location: Text,
enable_cache=enable_cache)
config = kubeflow_dag_runner.KubeflowDagRunnerConfig(
kubeflow_metadata_config=kubeflow_dag_runner.get_default_kubeflow_metadata_config(),
tfx_image='gcr.io/ml-pipeline/patched-tfx:0.1.32')
tfx_image='tensorflow/tfx:0.16.0.dev20191101')
kfp_runner = kubeflow_dag_runner.KubeflowDagRunner(config=config)
# Make sure kfp_runner recognizes those parameters.
kfp_runner._params.extend([_data_root_param, _taxi_module_file_param])
Expand Down