[Sample] Align preload TFX sample with TFX head #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Update ROADMAP.md Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Apply suggestions from code review Co-authored-by: Alexa Griffith <agriffith50@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Address comments Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Alexa Griffith <agriffith50@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample background:
There is a breaking change introduced in TFX side in this PR, adding a required argument
component_configtocontainer_entrypoint.py. As a result, if a user compile this uDSL file using TFX head but try to run it against ourpatched-tfx:0.1.32image, it will fail due to missing argument.I think it would a reasonable fix if we align this sample with TFX for now. After this change, when the user compile this sample from TFX head, a pipeline using latest TFX nightly build would be returned, which is consistent with the yaml spec. Though the generated yaml spec is slightly different from what we baked into our backend server, which I think is fine.
This change is