Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ai_platform test #2327

Merged
merged 6 commits into from
Oct 10, 2019
Merged

add ai_platform test #2327

merged 6 commits into from
Oct 10, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Oct 8, 2019 •
edited by jlewi
Loading

Add AI_platform sample test
debug the model delete permission issue.

This change is Reviewable

@numerology numerology self-assigned this Oct 8, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 8, 2019

Is this similar to #2236?

@numerology
Copy link

Is this similar to #2236?

I think @gaoning777 is investigating how to delete models and versions in the notebook, which is blocked by some permission issue.
In #2236 the plan is just run the pipeline and use some separate logic to GC the model and version generated during execution.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

Looks like the service accounts are working fine. @numerology

@gaoning777 gaoning777 changed the title [WIP] add ai_platform test add ai_platform test Oct 9, 2019
@gaoning777 gaoning777 mentioned this pull request Oct 9, 2019
Closed
@numerology
Copy link

/lgtm

Thanks @gaoning777 !

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 10, 2019
@jingzhang36
Copy link
Contributor

/lgtm

SinaChavoshi
SinaChavoshi reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e89aa48 into kubeflow:master Oct 10, 2019
@gaoning777
Copy link
Contributor Author

fixing #1813

@gaoning777 gaoning777 deleted the add-ai-platform branch October 10, 2019 04:10
@numerology numerology mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@jingzhang36 jingzhang36

@numerology numerology

@SinaChavoshi SinaChavoshi

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaoning777 @Ark-kun @numerology @jingzhang36 @k8s-ci-robot @SinaChavoshi