[Sample] Add AI platform sample test #2236
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
|
What is the benefit of renaming the samples and files? |
Currently, the sample test infra assumes that the test file and the dir have the same name. |
Would you mind if I fix that code at some point? (I won't block your work) |
Sure, that will be appreciated |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/retest |
…dd-mlengine-sample-test # Conflicts: # test/sample_test.yaml
…dd-mlengine-sample-test � Conflicts: � samples/core/ai_platform/ai_platform.ipynb
|
TODO: switch back to create_run_from_pipeline_func once it works in test infra. |
|
/retest |
…dd-mlengine-sample-test
numerology
changed the title
numerology
changed the title
| "arguments = {}\n", | ||
| "\n", | ||
| "# Submit a pipeline run\n", | ||
| "run_name = pipeline_func.__name__ + ' run'\n", |
There was a problem hiding this comment.
Is there any reason to set the run name?
|
Looks like the service accounts are working fine. PTAL: #2327 |
|
/close |
|
@numerology: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of #1813
Memo: Currently using a ad hoc logic in presubmit-tests-with-pipeline-deployment.sh to GC the generated models and versions. Long term solution should be that the notebook cleans up the generated files itself, but it requires further investigation on how to grant proper permission.
This change is