Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcp-connector label and remove pod name #1542

Merged
merged 5 commits into from
Jul 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/gcp/bigquery/query/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ name: Bigquery - Query
description: |
A Kubeflow Pipeline component to submit a query to Google Cloud Bigquery
service and dump outputs to a Google Cloud Storage blob.
metadata:
labels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use annotation instead of label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replied in another comment and you probably missed that. Label is better to serve as selector instead of annotation.

https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#equality-based-requirement

add-pod-env: 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have namespace prefix in the key name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this label is pretty common and not necessary to be KFP specific. Ideally, we should have a admission control which inject it to all pods in kf cluster.

inputs:
- name: query
description: 'The query used by Bigquery service to fetch the results.'
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataflow/launch_python/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: Launch Python
description: |
Launch a self-executing beam python file.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: python_file_path
description: 'The gcs or local path to the python file to run.'
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataflow/launch_template/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: Launch Dataflow Template
description: |
Launchs a dataflow job from template.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: 'Required. The ID of the Cloud Platform project that the job belongs to.'
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/create_cluster/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_create_cluster
description: |
Creates a DataProc cluster under a project.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/delete_cluster/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_delete_cluster
description: |
Deletes a DataProc cluster.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_hadoop_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ name: dataproc_submit_hadoop_job
description: >-
Submits a Cloud Dataproc job for running Apache Hadoop MapReduce jobs on
Apache Hadoop YARN.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_hive_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_submit_hive_job
description: >-
Submits a Cloud Dataproc job for running Apache Hive queries on YARN.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_pig_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_submit_pig_job
description: >-
Submits a Cloud Dataproc job for running Apache Pig queries on YARN.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_pyspark_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_submit_pyspark_job
description: >-
Submits a Cloud Dataproc job for running Apache PySpark applications on YARN.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_spark_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_submit_spark_job
description: >-
Submits a Cloud Dataproc job for running Apache Spark applications on YARN.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/dataproc/submit_sparksql_job/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: dataproc_submit_sparksql_job
description: >-
Submits a Cloud Dataproc job for running Apache Spark SQL queries.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/ml_engine/batch_predict/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
name: Batch predict against a model with Cloud ML Engine
description: |
Creates a MLEngine batch prediction job.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: 'Required. The ID of the parent project of the job.'
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/ml_engine/deploy/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ name: Deploying a trained model to Cloud Machine Learning Engine
description: |
A Kubeflow Pipeline component to deploy a trained model from a Cloud Storage
path to a Cloud Machine Learning Engine service.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: model_uri
description: >-
Expand Down
3 changes: 3 additions & 0 deletions components/gcp/ml_engine/train/component.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ name: Submitting a Cloud ML training job as a pipeline step
description: |
A Kubeflow Pipeline component to submit a Cloud Machine Learning (Cloud ML)
Engine training job as a step in a pipeline.
metadata:
labels:
add-pod-env: 'true'
inputs:
- name: project_id
description: 'Required. The ID of the parent project of the job.'
Expand Down