-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcp-connector label and remove pod name #1542
Changes from all commits
732bb7a
0a99ea8
078057a
42767e1
32cbd54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,9 @@ name: Bigquery - Query | |
description: | | ||
A Kubeflow Pipeline component to submit a query to Google Cloud Bigquery | ||
service and dump outputs to a Google Cloud Storage blob. | ||
metadata: | ||
labels: | ||
add-pod-env: 'true' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should have namespace prefix in the key name. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel this label is pretty common and not necessary to be KFP specific. Ideally, we should have a admission control which inject it to all pods in kf cluster. |
||
inputs: | ||
- name: query | ||
description: 'The query used by Bigquery service to fetch the results.' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use annotation instead of label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replied in another comment and you probably missed that. Label is better to serve as selector instead of annotation.
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#equality-based-requirement