Add gcp-connector label and remove pod name #1542
Conversation
|
Is the |
|
Is the gcp-connector label being used by the backend? |
| @@ -16,6 +16,9 @@ name: Bigquery - Query | |||
| description: | | |||
| A Kubeflow Pipeline component to submit a query to Google Cloud Bigquery | |||
| service and dump outputs to a Google Cloud Storage blob. | |||
| metadata: | |||
| labels: | |||
There was a problem hiding this comment.
Is it possible to use annotation instead of label?
There was a problem hiding this comment.
I have replied in another comment and you probably missed that. Label is better to serve as selector instead of annotation.
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#equality-based-requirement
| @@ -16,6 +16,9 @@ name: Bigquery - Query | |||
| description: | | |||
| A Kubeflow Pipeline component to submit a query to Google Cloud Bigquery | |||
| service and dump outputs to a Google Cloud Storage blob. | |||
| metadata: | |||
| labels: | |||
| add-pod-env: 'true' | |||
There was a problem hiding this comment.
Maybe we should have namespace prefix in the key name.
There was a problem hiding this comment.
I feel this label is pretty common and not necessary to be KFP specific. Ideally, we should have a admission control which inject it to all pods in kf cluster.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Modify all gcp component yaml to have gcp-connector label.
This change is