-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now pipeline function takes direct default values rather than dsp.PipelineParam. #110
Changes from all commits
22b3b13
076ebbb
854cb73
a1fe94a
305843a
63abaea
14508aa
73aa4c0
b953297
9a8bad6
6a942c5
112917a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,11 +14,21 @@ COPY . . | |
RUN apk add --update gcc musl-dev | ||
RUN go build -o /bin/apiserver backend/src/apiserver/*.go | ||
|
||
FROM python:3.5.0-slim as compiler | ||
FROM python:3.5 as compiler | ||
|
||
RUN apt-get update -y && \ | ||
apt-get install --no-install-recommends -y -q default-jdk wget | ||
|
||
RUN pip3 install setuptools==40.5.0 | ||
|
||
RUN wget http://central.maven.org/maven2/io/swagger/swagger-codegen-cli/2.3.1/swagger-codegen-cli-2.3.1.jar -O /tmp/swagger-codegen-cli.jar | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this for compilation? The compiler probably runs fine without the swagger codegen or kubernetes. |
||
|
||
WORKDIR /go/src/github.com/kubeflow/pipelines | ||
COPY . . | ||
WORKDIR /go/src/github.com/kubeflow/pipelines/sdk/python | ||
RUN ./build.sh /kfp.tar.gz | ||
RUN pip3 install /kfp.tar.gz | ||
|
||
# This is hard coded to 0.0.26. Once kfp DSK release process is automated, | ||
# we can dynamically refer to the version from same commit SHA. | ||
RUN pip install https://storage.googleapis.com/ml-pipeline/release/0.0.26/kfp-0.0.26.tar.gz --upgrade | ||
WORKDIR /samples | ||
COPY ./samples . | ||
RUN find . -maxdepth 2 -name "*.py" -exec dsl-compile --py {} --output {}.tar.gz \; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,6 +95,6 @@ def __init__(self, name, url): | |
name='Download and Save Most Frequent', | ||
description='Download and Get Most Frequent Word and Save to GCS' | ||
) | ||
def download_save_most_frequent_word(url: dsl.PipelineParam, outputpath: dsl.PipelineParam): | ||
def download_save_most_frequent_word(url: str, outputpath: str): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This type annotation is not used by DSL, right? it served to show the types to the users? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not used by DSL compiler. |
||
downloader = DownloadMessageOp('download', url) | ||
save_most_frequent_word(downloader.output, outputpath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no auto-installed? Do we need the specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes per @gaoning777 's investigation.